Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zulu timestamp for listBalances #652

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

btwlouis
Copy link
Contributor

Fix: Updated listBalances method to use Zulu format for as_of_time

  • Changed the date format to toIso8601ZuluString() to ensure correct UTC handling.
  • Added support for date parsing.
  • This fixes an issue where the previous implementation would no longer work with PayPal's API.
  • Tested the solution and confirmed it works as expected.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (5bbcec4) to head (ebdb52d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               v3.0     #652   +/-   ##
=========================================
  Coverage     96.01%   96.01%           
  Complexity      272      272           
=========================================
  Files            34       34           
  Lines          1130     1130           
=========================================
  Hits           1085     1085           
  Misses           45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srmklive srmklive merged commit 0a472c8 into srmklive:v3.0 Jan 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants